Crypto store: clear db before integ tests #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible for integ test results to leak from one test run to the next (for example, the indexeddb stores hang around in the browser), causing bad test results. Extend the test setup routine to clear out the store before the test starts.
poljar
approved these changes
Jul 3, 2024
Add a case that I forgot, and factor repeated code out
richvdh
force-pushed
the
rav/cryptostore_tests_clear_db
branch
from
57d0c68 to
11e5396
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3644 +/- ##
==========================================
+ Coverage 84.19% 84.22% +0.02%
==========================================
Files 256 256
Lines 26600 26600
==========================================
+ Hits 22397 22403 +6
+ Misses 4203 4197 -6 ☔ View full report in Codecov by Sentry. |
|
@poljar thanks for the quick review! I had to make a couple of other changes, but I don't think they are material, so will go ahead and land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible for integ test results to leak from one test run to the next (for example, the indexeddb stores hang around in the browser), causing bad test results.
Extend the test setup routine to clear out the store before the test starts.